Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encapsulate CA and Certificate operations #5544

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

WillardHu
Copy link
Collaborator

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Abstract some methods for certificates, and implement x509

Which issue(s) this PR fixes:

A part of issue #5498

Special notes for your reviewer:

The PR #5502 needs to be merged first.

Does this PR introduce a user-facing change?:


@kubeedge-bot kubeedge-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Apr 17, 2024
@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign willardhu after the PR has been reviewed.
You can assign the PR to them by writing /assign @willardhu in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@WillardHu WillardHu changed the title Encapsulate CA and Certificate operations [WIP] Encapsulate CA and Certificate operations Apr 17, 2024
@kubeedge-bot kubeedge-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 17, 2024
@WillardHu WillardHu force-pushed the enhance-certs branch 2 times, most recently from 1b5f97b to d052b96 Compare April 19, 2024 07:05
@WillardHu WillardHu force-pushed the enhance-certs branch 2 times, most recently from 907a8ab to e74b064 Compare April 28, 2024 09:27
@WillardHu WillardHu force-pushed the enhance-certs branch 3 times, most recently from 3639fea to 85b62ae Compare May 10, 2024 06:08
@WillardHu WillardHu changed the title [WIP] Encapsulate CA and Certificate operations Encapsulate CA and Certificate operations May 10, 2024
@kubeedge-bot kubeedge-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 10, 2024
@WillardHu WillardHu closed this May 10, 2024
@WillardHu WillardHu reopened this May 10, 2024
@WillardHu
Copy link
Collaborator Author

This change passed some tests in my k8s cluster

  • Cloudcore generates a self-signed ca certificate initially ✅
  • An new joined edge node(Edgecore) can connect to Cloudcore and obtains a service certificate ✅

PTAL @fisherxu @Shelley-BaoYue

@WillardHu WillardHu closed this May 10, 2024
@WillardHu WillardHu reopened this May 10, 2024
@WillardHu WillardHu closed this May 10, 2024
@WillardHu WillardHu reopened this May 10, 2024
Signed-off-by: WillardHu <wei.hu@daocloud.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants