-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Encapsulate CA and Certificate operations #5544
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1b5f97b
to
d052b96
Compare
907a8ab
to
e74b064
Compare
3639fea
to
85b62ae
Compare
This change passed some tests in my k8s cluster
PTAL @fisherxu @Shelley-BaoYue |
Signed-off-by: WillardHu <wei.hu@daocloud.io>
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Abstract some methods for certificates, and implement x509
Which issue(s) this PR fixes:
A part of issue #5498
Special notes for your reviewer:
The PR #5502 needs to be merged first.
Does this PR introduce a user-facing change?: