Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix device mapper data collecting cycle calculation error #5523

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix device mapper data collecting cycle calculation error #5523

wants to merge 2 commits into from

Conversation

tangming1996
Copy link
Contributor

What type of PR is this?
/kind bug

What this PR does / why we need it:
The device mapper data collecting cycle is too short, causing the mapper to crash.
Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@tangming1996 tangming1996 force-pushed the bugfix/device branch 2 times, most recently from b47246c to 27f0e9b Compare April 10, 2024 02:58
wbc6080
wbc6080 reviewed Apr 10, 2024
View reviewed changes
Copy link
Contributor

@wbc6080 wbc6080 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Users can set the frequency for mapper to report data in the device-instance configuration file refer to page. The default is to report once per second.

@wbc6080
Copy link
Contributor

wbc6080 commented Apr 10, 2024

cycle

@fisherxu fisherxu closed this Apr 10, 2024
@fisherxu fisherxu reopened this Apr 10, 2024
@kubeedge-bot kubeedge-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 10, 2024
@tangxiaoming1
Copy link

cycle

Thank you for your reply. I understand what you mean, but the unit of data collecting cycle is defined by mapper. I think millisecond as the minimum unit is sufficient, and the readability will be higher. I used 1000 nanoseconds in the real environment, and mapper just crashed.

Shelley-BaoYue
Shelley-BaoYue reviewed Apr 11, 2024
View reviewed changes
Copy link
Collaborator

@Shelley-BaoYue Shelley-BaoYue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are something wrong with ci and I have solved it and merge it into master. Please rebase the new master branch and push again. Thx : ）

@tangming1996
Copy link
Contributor Author

There are something wrong with ci and I have solved it and merge it into master. Please rebase the new master branch and push again. Thx : ）

Okay, I already rebase master.

Shelley-BaoYue
Shelley-BaoYue reviewed Apr 19, 2024
View reviewed changes
Copy link
Collaborator

@Shelley-BaoYue Shelley-BaoYue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kubeedge-bot kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 19, 2024
@kubeedge-bot kubeedge-bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 22, 2024
@kubeedge-bot
Copy link
Collaborator

New changes are detected. LGTM label has been removed.

@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign fisherxu after the PR has been reviewed.
You can assign the PR to them by writing /assign @fisherxu in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 22, 2024
@kubeedge-bot kubeedge-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 23, 2024
@tangming1996
fix device mapper data collecting cycle calculation error.
cb99e3c 
Signed-off-by: ming.tang <ming.tang@daocloud.io>
wbc6080
wbc6080 reviewed Apr 23, 2024
View reviewed changes
Copy link
Contributor

@wbc6080 wbc6080 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pleause pass the CI test, you can re-run them by reopen this PR

@tangming1996 tangming1996 reopened this Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fisherxu fisherxu fisherxu left review comments

@wbc6080 wbc6080 wbc6080 left review comments

@Shelley-BaoYue Shelley-BaoYue Shelley-BaoYue left review comments

Assignees
No one assigned
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@tangming1996 @wbc6080 @tangxiaoming1 @kubeedge-bot @fisherxu @Shelley-BaoYue