Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce log verbosity for metrics "receive stop signal" #5510

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Links2004
Copy link

What type of PR is this?
/kind cleanup

What this PR does / why we need it:

reduce log verbosity for metrics "receive stop signal".

currently the log is cluttered with "receive stop signal, so stop metrics scan ..."
e.g.:

I0406 11:21:42.146160     797 edgedmetricsconnection.go:136] receive stop signal, so stop metrics scan ...
I0406 11:21:42.411512     797 edgedmetricsconnection.go:136] receive stop signal, so stop metrics scan ...
I0406 11:21:57.266068     797 edgedmetricsconnection.go:136] receive stop signal, so stop metrics scan ...
I0406 11:21:57.561080     797 edgedmetricsconnection.go:136] receive stop signal, so stop metrics scan ...
I0406 11:22:12.160770     797 edgedmetricsconnection.go:136] receive stop signal, so stop metrics scan ...
I0406 11:22:12.455189     797 edgedmetricsconnection.go:136] receive stop signal, so stop metrics scan ...

this kind of log entrys do not help during normal operation and are created for each request of the metrics-server as a result i decresed the verbosity of them to the same level that is used in the rest of the file.

Special notes for your reviewer:

Does this PR introduce a user-facing change?:
NONE

reduce log verbosity for metrics endpoint logs "receive stop signal".

Copy link
Contributor

@wbc6080 wbc6080 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks for your contribution!

@Links2004
Copy link
Author

/retest
how to trigger a rerun of the failed tests?

@kubeedge-bot
Copy link
Collaborator

@Links2004: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest
how to trigger a rerun of the failed tests?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Links2004
Copy link
Author

@wbc6080 can you please restart the tests, so that this can be merged?

Copy link
Contributor

@wbc6080 wbc6080 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took a look and found that we have fixed the failed ci test in other PRs. You can rebase the latest code to try again.

Signed-off-by: Links2004 <help.markus+gitk@gmail.com>
@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign sids-b after the PR has been reviewed.
You can assign the PR to them by writing /assign @sids-b in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 11, 2024
@Links2004
Copy link
Author

please approve the run of the CI/CD

Copy link
Contributor

@wbc6080 wbc6080 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you help to run the CI test? thanks @WillardHu @Shelley-BaoYue @fisherxu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants