-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reduce log verbosity for metrics "receive stop signal" #5510
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks for your contribution!
/retest |
@Links2004: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@wbc6080 can you please restart the tests, so that this can be merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took a look and found that we have fixed the failed ci test in other PRs. You can rebase the latest code to try again.
Signed-off-by: Links2004 <help.markus+gitk@gmail.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
please approve the run of the CI/CD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you help to run the CI test? thanks @WillardHu @Shelley-BaoYue @fisherxu
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
reduce log verbosity for metrics "receive stop signal".
currently the log is cluttered with "receive stop signal, so stop metrics scan ..."
e.g.:
this kind of log entrys do not help during normal operation and are created for each request of the
metrics-server
as a result i decresed the verbosity of them to the same level that is used in the rest of the file.Special notes for your reviewer:
Does this PR introduce a user-facing change?:
NONE