-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FeatureGate support for keadm join command #5508
base: master
Are you sure you want to change the base?
Conversation
3337d49
to
4163e71
Compare
Signed-off-by: micplus <ain01a@outlook.com>
Signed-off-by: micplus <ain01a@outlook.com>
Signed-off-by: micplus <ain01a@outlook.com>
4163e71
to
1634f24
Compare
Signed-off-by: micplus <ain01a@outlook.com>
Signed-off-by: micplus <ain01a@outlook.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/assign @WillardHu @Shelley-BaoYue
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fisherxu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I have a different opinion. --set will be supported in next release, then we can use --set to configure featuregates. Does this pr still need to be merged in this release? |
@micplus: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
As mentioned in #5507, we can add
featuregates
flag tokeadm join
command. Then users can enable new alpha features when setting up edge nodes by keadm.Which issue(s) this PR fixes:
Fixes #5507
Special notes for your reviewer:
Does this PR introduce a user-facing change?: