Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FeatureGate support for keadm join command #5507

Open
micplus opened this issue Apr 4, 2024 · 0 comments · May be fixed by #5508
Open

Add FeatureGate support for keadm join command #5507

micplus opened this issue Apr 4, 2024 · 0 comments · May be fixed by #5508
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@micplus
Copy link
Contributor

micplus commented Apr 4, 2024

What would you like to be added/modified:

Support FeatureGate for keadm join

Why is this needed:

For new features in alpha development, KubeEdge users cannot enable these features by keadm join command.

To make keadm more user-friendly, we can add featuregates flag to keadm join.

With featuregates flag, users can enable new features by

keadm join --cloudcore-ipport=0.0.0.0:8080 --featuregates=feature1,feature2

Then here comes /etc/kubeedge/config/edgecore.yaml with featureGates, and keadm will run edgecore with new features enabled:

apiVersion: edgecore.config.kubeedge.io/v1alpha2
database:
  aliasName: default
  dataSource: /var/lib/kubeedge/edgecore.db
  driverName: sqlite3
featureGates:
  feature1: true
  feature2: true
kind: EdgeCore
modules:
  dbTest:
    enable: false
  deviceTwin:
    dmiSockPath: /etc/kubeedge/dmi.sock
    enable: true
// ....
// ....
@micplus micplus added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 4, 2024
@micplus micplus linked a pull request Apr 4, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant