Ability to Add Data in Reports #9
Conversation
If you want the user to give a message regarding the previous crash.
|
|
||
| if(removeOldKey) | ||
| { | ||
| [report removeObjectForKey:@KSCrashField_UserAtCrash]; |
There was a problem hiding this comment.
Instead of removing the entire user dictionary, why not use -[NSDictionary mergedInto:] from NSDictionary+Merge?
There was a problem hiding this comment.
Actually I removed the old dictionary whether it is "User" or "UserAtCrash" and replace it with a UserAtCrash dictionary containing the previous as well as the new info...
What is your opinion as you know the system and architecture best.
There was a problem hiding this comment.
It seems that what this method is doing is actually replacing the user dictionary with a different one. To keep it in the spirit of its name (adding a custom key to the user data), it should add/replace the key inside the user dictionary rather than replacing the entire dictionary with a new one containing only that key.
Actually, this could be made even more useful if it were:
- (void) setObject:(id) object forKey:(NSString*) key inUserDataInCrashReportWithID:(NSString*) reportID
Where "object" is a JSON serializable type.
If the user data dictionary doesn't exist, it is created. If it does, the object gets added to it.
If the key doesn't exist, it is created. If it does exist, it is replaced.
Also, since "user" and "user at crash" variants get merged by KSCrashReportStore when you load a report, you don't even need to handle both in this code. Just stuff it in "user" and let the report store do the merging work later.
|
It would be great, if the user could add additional information to a (previous) crash for a better understanding of the bug. Is this possible with email? |
If you want the user to give a message regarding the previous crash, you can use the new utility method in CrashReportStore