Refactor SPM Modules #462
Merged
Refactor SPM Modules #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GLinnik21
commented
Apr 18, 2024
GLinnik21
commented
Apr 29, 2024
|
Thanks you a lot for such an amazing effort for structuring the modules. |
bamx23
reviewed
Apr 30, 2024
| @@ -35,36 +35,35 @@ @interface KSThread_Tests : XCTestCase @end | |||
|
|
|||
| @implementation KSThread_Tests | |||
|
|
|||
| // TODO: Disabling this until I figure out what's wrong with queue names. | |||
There was a problem hiding this comment.
Have you figured out what's wrong with the queue names?
There was a problem hiding this comment.
Not quite.
I was just looking through other pull requests and found this #221. Don't think that it would be compatible with my changes. By the way tests passes fine.
GLinnik21
force-pushed
the
new_package_manifest
branch
from
8afa591
to
384c1a9
Compare
Open
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR restructures our project to support modular imports in Swift Package Manager (SPM), addressing the inefficiencies of the current complex and non-standard target structure. It sets the foundation for future enhancements in privacy compliance and build system compatibility.
Key Changes
This restructuring prepares the library for future improvements, making it more manageable and ensuring compatibility with modern build environments.
High-Level Design of KSCrash modules. Thanks to @bamx23.
This PR addresses issue #458.