Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ksobjc_objectType error #422

Merged
merged 2 commits into from May 5, 2024
Merged

Fix ksobjc_objectType error #422

merged 2 commits into from May 5, 2024

Conversation

xuezhulian
Copy link
Contributor

NSObject *obj = [NSObject new];
ksobjc_objectType((__bridge void *)obj);

Both object and block return KSObjCTypeUnknown.

NSObject *obj = [NSObject new];
ksobjc_objectType((__bridge void *)obj);

Both object and block return KSObjCTypeUnknown.
@GLinnik21
Copy link
Collaborator

GLinnik21 commented Jan 6, 2023

Shouldn't Source/KSCrash-Tests/KSObjC_Tests.m be fixed as well?

@xuezhulian
Copy link
Contributor Author

KSObjC_Tests does not need to be modified, all the units start with testObjectType have passed.

@GLinnik21
Copy link
Collaborator

@bamx23 should we merge to master or move to release-2.0?

@bamx23 bamx23 merged commit 656456d into kstenerud:master May 5, 2024
@bamx23
Copy link
Collaborator

bamx23 commented May 5, 2024

Let's merge to master and update release-2.0 from it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants