-
Notifications
You must be signed in to change notification settings - Fork 975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Google Cloud Storage support to Storage Spec #3495
base: master
Are you sure you want to change the base?
Conversation
@@ -1429,7 +1429,7 @@ func TestCredentialBuilder_CreateStorageSpecSecretEnvs(t *testing.T) { | |||
Name: "storage-secret", | |||
Namespace: namespace, | |||
}, | |||
StringData: map[string]string{"minio": "{\n \"type\": \"gs\",\n \"access_key_id\": \"minio\",\n \"secret_access_key\": \"minio123\",\n \"endpoint_url\": \"http://minio-service.kubeflow:9000\",\n \"bucket\": \"test-bucket\",\n \"region\": \"us-south\"\n }"}, | |||
StringData: map[string]string{"minio": "{\n \"type\": \"gss\",\n \"access_key_id\": \"minio\",\n \"secret_access_key\": \"minio123\",\n \"endpoint_url\": \"http://minio-service.kubeflow:9000\",\n \"bucket\": \"test-bucket\",\n \"region\": \"us-south\"\n }"}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this intentional? Why wasn't this failing before?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this intentional? Why wasn't this failing before?
Hi @terrytangyuan , thanks for your feedback.
Yes, this change is intentional. Before this PR, the 'gs' type wasn't supported, the test would fail.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quite related to Dan comment, but I don't think it makes sense to force this to fail, by doing this change. The test should be reworked to properly validate the GS support (or fully remove it, and create a new one from stracth).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Signed-off-by: tjandy98 <3953059+tjandy98@users.noreply.github.com>
8fbb091
to
ee9f271
Compare
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: lizzzcai, terrytangyuan, tjandy98 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -139,6 +139,21 @@ def _update_with_storage_spec(): | |||
f.write(value) | |||
f.flush() | |||
|
|||
if storage_secret_json.get("type", "") == "gs": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe move gs and other supported types to constants?
New changes are detected. LGTM label has been removed. |
2c82d58
to
ee9f271
Compare
Signed-off-by: tjandy98 <3953059+tjandy98@users.noreply.github.com>
c26baff
to
98c58bf
Compare
Signed-off-by: tjandy98 <3953059+tjandy98@users.noreply.github.com>
Signed-off-by: tjandy98 <3953059+tjandy98@users.noreply.github.com>
…into storage-spec-gcs
Signed-off-by: tjandy98 <3953059+tjandy98@users.noreply.github.com>
@tjandy98 can you please send a empty commit to retrigger CI? |
Signed-off-by: tjandy98 <3953059+tjandy98@users.noreply.github.com>
What this PR does / why we need it:
Add gcs service account support to the existing storage spec
Type of changes
Documentation: kserve/website#351