Skip to content

Commit

Permalink
Merge pull request uc-cdis#159 from uc-cdis/feat/manifestGlobalPatch
Browse files Browse the repository at this point in the history
Manifest-global enhancements
  • Loading branch information
EliseCastle23 committed Mar 15, 2024
2 parents 67367e2 + ddb6fe0 commit dcfb3a7
Show file tree
Hide file tree
Showing 5 changed files with 13 additions and 5 deletions.
4 changes: 2 additions & 2 deletions .secrets.baseline
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"files": "^.secrets.baseline$",
"lines": null
},
"generated_at": "2024-03-11T18:38:21Z",
"generated_at": "2024-03-15T18:22:32Z",
"plugins_used": [
{
"name": "AWSKeyDetector"
Expand Down Expand Up @@ -330,7 +330,7 @@
"hashed_secret": "9b5925ea817163740dfb287a9894e8ab3aba2c18",
"is_secret": false,
"is_verified": false,
"line_number": 174,
"line_number": 176,
"type": "Secret Keyword"
}
],
Expand Down
2 changes: 1 addition & 1 deletion helm/gen3/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 0.1.24
version: 0.1.25

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
Expand Down
3 changes: 2 additions & 1 deletion helm/gen3/README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# gen3

![Version: 0.1.24](https://img.shields.io/badge/Version-0.1.24-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: master](https://img.shields.io/badge/AppVersion-master-informational?style=flat-square)
![Version: 0.1.25](https://img.shields.io/badge/Version-0.1.25-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: master](https://img.shields.io/badge/AppVersion-master-informational?style=flat-square)

Helm chart to deploy Gen3 Data Commons

Expand Down Expand Up @@ -88,6 +88,7 @@ Helm chart to deploy Gen3 Data Commons
| global.externalSecrets.dbCreate | bool | `false` | Will create the databases and store the creds in Kubernetes Secrets even if externalSecrets is deployed. Useful if you want to use ExternalSecrets for other secrets besides db secrets. |
| global.externalSecrets.deploy | bool | `false` | Will use ExternalSecret resources to pull secrets from Secrets Manager instead of creating them locally. Be cautious as this will override secrets you have deployed. |
| global.hostname | string | `"localhost"` | Hostname for the deployment. |
| global.manifestGlobalExtraValues | map | `{}` | If you would like to add any extra values to the manifest-global configmap. |
| global.netPolicy | bool | `true` | Whether network policies are enabled. |
| global.portalApp | string | `"gitops"` | Portal application name. |
| global.postgres.dbCreate | bool | `true` | Whether the database create job should run. |
Expand Down
7 changes: 6 additions & 1 deletion helm/gen3/templates/global-manifest.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,9 @@ data:
"dd_enabled": {{ .Values.global.ddEnabled | quote }}
{{- with .Values.global.origins_allow_credentials }}
"origins_allow_credentials": {{ . | toJson | quote }}
{{- end -}}
{{- end -}}
{{- with .Values.global.manifestGlobalExtraValues }}
{{- range $key, $value := . }}
{{ $key }}: {{ $value | quote }}
{{- end }}
{{- end }}
2 changes: 2 additions & 0 deletions helm/gen3/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,8 @@ global:
dispatcherJobNum: "10"
# -- (bool) Whether Datadog is enabled.
ddEnabled: false
# -- (map) If you would like to add any extra values to the manifest-global configmap.
manifestGlobalExtraValues: {}
# -- (map) External Secrets settings.
externalSecrets:
# -- (bool) Will use ExternalSecret resources to pull secrets from Secrets Manager instead of creating them locally. Be cautious as this will override secrets you have deployed.
Expand Down

0 comments on commit dcfb3a7

Please sign in to comment.