New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: useViewportScrollCoords & useViewportScale fall back properly #269

Open

DougReeder wants to merge 1 commit into kripod:master from DougReeder:master

DougReeder commented Oct 4, 2021

Both hooks fall back properly when window.visualViewport isn't defined (as in jsdom when running tests, or an old browser)
useViewportScale falls back to 1.0 rather than 0
useViewportScrollCoords also updates on resize events resize


          fix: useViewportScrollCoords & useViewportScale fall back properly

52f5a26

Author

DougReeder commented Oct 4, 2021

I don't know why the Build Errored, but it builds fine and the tests pass for me, using node 14.16.1 under MacOS 11.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment