Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce memory per shm string by 8 bytes #465

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Reduce memory per shm string by 8 bytes #465

wants to merge 1 commit into from

Commits on Nov 5, 2022

  1. Reduce memory per shm string by 8 bytes 

    Related to krakjoe#323

This slightly helps performance of `apc.serializer=default`
when there are lots of small strings to unpersist.
(and reduces size of serialized data by 8 bytes with other serializers)

With APCu's current design and eviction always being a possibility,
strings must always be copied.
(zval flags could be used to check the type if that stopped being the case)

For example, fetching an array mapping small strings to small strings:

	Before: bench_apcu_fetch_large_config: numValues=     65536
	repetitions=       256 elapsed=3.010 shared memory=   9381144
	After: bench_apcu_fetch_large_config: numValues=     65536
	repetitions=       256 elapsed=2.980 shared memory=   8332560
    @TysonAndre
    TysonAndre committed Nov 5, 2022
    Configuration menu
    Copy the full SHA
    c659f6c View commit details
    Browse the repository at this point in the history