Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support flag for status policy #4129

Merged
merged 3 commits into from May 21, 2024

Conversation

fsommar
Copy link
Contributor

@fsommar fsommar commented Mar 15, 2024

The default behavior is still to use --status-policy=all. The option is there for users that want to avoid the status behavior for various reasons. In our case, we use kpt live apply in our CI/CD pipelines, but don't need it saving statuses for all resources into the inventory. Thus, we want to be able to pass --status-policy=none.

I created a partner PR in kubernetes-sigs/cli-utils#637. The idea is to have that merged first and then rely on that flagutils func in this PR.

If this flag has been intentional withheld from users, can we consider having this flag hidden instead?

@fsommar
Copy link
Contributor Author

fsommar commented Apr 2, 2024

Rebased on main; the failing checks seem unrelated, and go generate works locally after rebase.

@droot droot requested a review from mortent April 15, 2024 16:11
@fsommar
Copy link
Contributor Author

fsommar commented Apr 17, 2024

Failure looks unrelated; let me know if I should rebase again.

@tomasaschan
Copy link

/retest

@justinsb
Copy link
Contributor

Thank you @fsommar - there's some code repetition here in the existing code (it looks like we started live.NewClusterClientFactory but never really finished it).

I'm OK to merge as-is, but I also am checking whether I have permissions to merge kubernetes-sigs/cli-utils#637

@justinsb
Copy link
Contributor

Looks like I don't have permissions, so I'm going to apply hold & approve & lgtm. If you want to merge before the cli-utils PR, just remove the hold :-)

/approve
/lgtm
/hold

@fsommar
Copy link
Contributor Author

fsommar commented May 14, 2024

I've upgrade to the latest cli-utils release with my changes and cleaned up the history.

/assign justinsb

@tomasaschan
Copy link

/hold cancel

@mortent
Copy link
Contributor

mortent commented May 20, 2024

The Porch-related test failures here can be ignored, as that will be handled by #4153. But the TestFnEval failure doesn't seem related to Porch. We can see if that still fails after we rebase this PR on top of #4153.

@mortent
Copy link
Contributor

mortent commented May 20, 2024

The PR that removes Porch from the repo has merged. Can you rebase this one and it should address most of the test failures?

Signed-off-by: Fredrik Sommar <fred.sommar+github@gmail.com>
The fix kyaml function is no longer available in the same location
upstream, and because there are no other dependencies here I decided to
remove it.

Signed-off-by: Fredrik Sommar <fred.sommar+github@gmail.com>
The default behavior is still to use --status-policy=all. For users that
want to avoid the status behavior for various reasons.

Signed-off-by: Fredrik Sommar <fred.sommar+github@gmail.com>
@kptdev-robot kptdev-robot bot merged commit 72a151f into kptdev:main May 21, 2024
1 check passed
@fsommar
Copy link
Contributor Author

fsommar commented May 21, 2024

It went through without tests running 😅 At least they were passing locally. I noticed too late that I accidentally included the go version files in the porch directory after rebasing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants