Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update kyaml deps #3901

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

update kyaml deps #3901

wants to merge 1 commit into from

Conversation

droot
Copy link
Contributor

@droot droot commented Apr 3, 2023

This PR tries to update the kyaml dependencies for kpt CLI. I am running into an error that I am afraid requires updating the upstream k8s dependencies as well. So treat this as work in progress.

k8s.io/cli-runtime/pkg/resource
# k8s.io/cli-runtime/pkg/resource
../../../../../go/pkg/mod/k8s.io/cli-runtime@v0.25.3/pkg/resource/kustomizevisitor.go:41:8: kOpts.DoLegacyResourceSort undefined (type *krusty.Options has no field or method DoLegacyResourceSort)
make: *** [Makefile:46: build] Error 2

@droot droot mentioned this pull request Apr 3, 2023
Open
@justinsb
Copy link
Contributor

justinsb commented Oct 4, 2023

/lgtm

(Really testing if lgtm works!)

@kptdev-robot kptdev-robot bot added the lgtm label Oct 4, 2023
@justinsb
Copy link
Contributor

justinsb commented Oct 4, 2023

/lgtm cancel

@kptdev-robot kptdev-robot bot added lgtm and removed lgtm labels Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@droot @justinsb