Slim down produced docker image #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Save the bytes! Also make builds without cached layers faster. And
images lighter to move around.
Basic stuff like:
- using slim image
- adding node_modules to .dockerignore
Some aditional changes due to:
- New slim debian image (bookworm) no longer bundles libssl, so it has
to be install explicitly as prisma depends on it. See: nodejs/docker-node#1919
- Bookworm uses different version of libssl 3.0.x rather than 1.1.x
which necesatates update to prisma schema.
- Prisma client itself has to be updated to support libssl 3.0.x.
Question: Should we pin the OS version to avoid such surprises in the
future?
PRO: Consistent OS experience.
CON: OS version has to be bumped manually on new release.
Resources
- Some recommendations regarding images: https://snyk.io/blog/choosing-the-best-node-js-docker-image/
- Why dockerignore: https://codefresh.io/blog/not-ignore-dockerignore-2/
New image size: 648MB
Original image size: 1.62GB
mzgajner
approved these changes
Jul 5, 2023
There was a problem hiding this comment.
New image size: 648MB
Original image size: 1.62GB
💯 Thanks for the extensive explanation too.
I wouldn't pin the OS version for now, simply because this is currently just a way to set up the dev environment. We can reconsider if/when it becomes an actual production image.
...like it's 2014 🎆
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Save the bytes! Also, make builds without cached layers faster. And images lighter to move around.
Basic stuff like:
Some additional changes due to:
node:lts-slimdoes not include OpenSSL as it is now based on bookworm because of upstream change indebian:bookworm-slimimage nodejs/docker-node#1919Question: Should we pin the OS version to avoid such surprises in the future?
PRO: Consistent OS experience.
CON: OS version has to be bumped manually on a new release.
Resources
New image size: 648MB
Original image size: 1.62GB