Support LSP4IJ, which is a third-party LSP server integration #437
Conversation
build.gradle.kts
Outdated
| @@ -27,6 +32,14 @@ dependencies { | |||
| compileOnly(libs.ini4j) | |||
| compileOnly(libs.kotlinxSerialization) | |||
| testImplementation(kotlin("test")) | |||
| // implementation("com.redhat.devtools:lsp4ij:0.10.0") | |||
| implementation("org.eclipse.lsp4mp:org.eclipse.lsp4mp.ls:0.10.0") { | |||
There was a problem hiding this comment.
You dont need lsp4mp which ptovide a microprofile ls and dont need qute ls
There was a problem hiding this comment.
Thank you for your comment.
I just removed it.
Qodana Community for JVM30 new problems were found
💡 Qodana analysis was run in the pull request mode: only the changed files were checked View the detailed Qodana reportTo be able to view the detailed Qodana report, you can either:
To get - name: 'Qodana Scan'
uses: JetBrains/qodana-action@v2024.1.2
with:
upload-result: trueContact Qodana teamContact us at qodana-support@jetbrains.com
|
| class RuffLsp4IntellijClient(val project: Project): RuffLspClient { | ||
| private val lspServer get() = RuffLanguageServerFactory().createConnectionProvider(project) | ||
| override fun start() { | ||
| lspServer.start() |
There was a problem hiding this comment.
@angelozerr @fbricon
Can I start/stop the LSP server without an extension point?
I want to switch LSP server by using GUI settings.
There was a problem hiding this comment.
yes you can stop it from the LSP console view: https://github.com/redhat-developer/lsp4ij/blob/main/docs/UserGuide.md#lsp-console
There was a problem hiding this comment.
Thank you. Is it difficult to switch using code without using the UI? If not, we will have to change the implementation policy. I'm thinking of switching to the original Idea function from the settings.
There was a problem hiding this comment.
I'm sorry I'm not sure I understand your question
There was a problem hiding this comment.
Can I start/stop the LSP server without an extension point?
Could you explain why you don't want to use the extension point to define your language server? I have the impression that you want to enable / disable with Java code (and not with LSP console menu actions) the language server, right?
There was a problem hiding this comment.
Sorry for the poor explanation.
Currently the lsp functionality is optional and can be enabled by the user checking it in the settings.
The current implementation only starts the LSP functionality made by Jetbrains when this option is enabled.
Secondly, I consider LSP4IJ to be the second option implemented.
In other words, in addition to switching the current LSP functionality (server) on and off, I believe there should be the ability to switch between the JetBrains LSP functionality or LSP4IJ.
You can actually understand this by looking at the screenshots.
If it is difficult to switch on/off from the java code, we will consider dropping support for LSP made by JetBrains.
However, the LSP functionality in ruff is optional and unless you have the latest Ruff or ruff-lsp installed, you will not be able to use LSP, otherwise you will have to directly hit the ruff command without LSP to provide features such as inspection.
We also believe that it is necessary to restart the LSP server, e.g. after the installation of a package for each project. (e.g. if we do a pip install and install the latest version of ruff-lsp, we want the plugin to detect the update and restart the lsp function).
There was a problem hiding this comment.
Thanks for the explication. As your usecase could interest other people could you please create an issue in lsp4ij. Thanks.
Managing language server like start/stop disable/enable are doable since we do that internally but we need perhaps provide API to manage that.
There was a problem hiding this comment.
@koxudaxi I created an issue at redhat-developer/lsp4ij#314 I will work on it and once I will some better idea I will fill my idea in the issue description. Please follow this issue
Related Issues: #415 (comment)