Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Support any future build incl EAP #868

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ciarancourtney
Copy link

@ciarancourtney ciarancourtney commented Jan 30, 2024

Since the plugin has been quite stable for a while, it may be easier to find bugs during EAP releases and fix them here, instead of excluding EAP builds from finding these bugs before GA. The proportion of EAP to GA users has got to be less than 5%?

Copy link

codecov bot commented Feb 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2326d0f) 72.27% compared to head (f18f0e9) 72.27%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #868   +/-   ##
=======================================
  Coverage   72.27%   72.27%           
=======================================
  Files          27       27           
  Lines        2099     2099           
  Branches      646      646           
=======================================
  Hits         1517     1517           
  Misses        276      276           
  Partials      306      306           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@koxudaxi
Copy link
Owner

@ciarancourtney
I'm sorry for my late reply.
It is certainly fine when only the EAP is released, but when the official version is released, it seems a bit problematic.
If a new version has API change destructive changes and existing users only upgrade their PyCharm version without updating the plugin, they will silently get a lot of errors.

@ciarancourtney
Copy link
Author

No worrries @koxudaxi in that case maybe a nightly > stable release cadence would be better

@koxudaxi
Copy link
Owner

@ciarancourtney

in that case maybe a nightly > stable release cadence would be better

I'm sorry, could you please elaborate on what you mean here?
Do you mean that you will also release a nightly version of the plugin?

@ciarancourtney
Copy link
Author

@ciarancourtney

in that case maybe a nightly > stable release cadence would be better

I'm sorry, could you please elaborate on what you mean here? Do you mean that you will also release a nightly version of the plugin?

Yes exactly, a nightly release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants