[WIP] add support for CartoCSS 1.x #281
Conversation
| if (output.msg) { | ||
| output.msg.forEach(function (v) { | ||
| if (v.type === 'error') { | ||
| console.error(carto.Util.getMessageToPrint(v)); |
There was a problem hiding this comment.
This is only for illustrational purposes and needs to be reworked.
|
I'll have a look at this asap :) |
|
@yohanboniface Hi, could you look at this PR? There's a fresh CartoCSS 1.1.0 release (mapbox/carto#494 (comment)), which adds new functionality ( |
|
Merged 8bb8cae Thanks @nebulon42 :) |
|
@kocio-pl merged, seems good to me (tested locally), please report errors on your side if any |
|
Thanks for the fast reaction. 😄 Great, it works! I will test it a bit more, especially to make sure there are no strange inter-project dependecies. Do you plan new release + NPM package anytime soon? |
Yep, cleaning deps and I'll do that. |
CartoCSS 1.0.0 had a breaking change in its JavaScript API. Now it is able to output warnings in addition to errors and errors are no longer emitted on stdout but returned in a special error property alongside the output data.
@yohanboniface I need your help with putting the new error output into the container that pops up at the bottom of the map. Also we need to clarify some other things. I think we would emit warnings to the console instead of to the map display. For some warnings may be too verbose, so we might want to give the user the chance to switch them off. CartoCSS supports that via a API switch, but we would need to put a similar config option into the Kosmtik config file.