Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Kotlin/JS and Kotlin/Native #23

Draft
wants to merge 24 commits into
base: main
Choose a base branch
from
Draft

Add support for Kotlin/JS and Kotlin/Native #23

wants to merge 24 commits into from

Conversation

DRSchlaubi
Copy link
Member

@DRSchlaubi DRSchlaubi commented Apr 16, 2023 •
edited

This PR doe:

lukellmann
lukellmann reviewed Apr 16, 2023
View reviewed changes
Copy link
Member

@lukellmann lukellmann left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you sure that identifiers that don't start with a number are invalid js names? (e.g. smilingFaceWith3Hearts, seems to be a totally valid js name)

@DRSchlaubi
Copy link
Member Author

DRSchlaubi commented Apr 16, 2023 •
edited

are you sure that identifiers that don't start with a number are invalid js names? (e.g. smilingFaceWith3Hearts, seems to be a totally valid js name)

Yep checked it, ja identifiers cannot contain numbers at all

Just consulted google and it should work unless it's the first character, don't know what I did wrong

@lukellmann
Copy link
Member

Just consulted google and it should work unless it's the first character, don't know what I did wrong

then the js name should probably just be prepended with _ if it starts with a digit, in other cases i would keep the mangling

@DRSchlaubi
More cleanup
1093ed9
@DRSchlaubi
Switch to version catalogs
56b370b
@DRSchlaubi
Add publishing again
d6a1838
@DRSchlaubi
Do not publish javadoc jar for now
e41f464
@DRSchlaubi
Fix tests
0c587f6
@DRSchlaubi
FIX CI
52018d3
@DRSchlaubi
Updates
077f636 
- Switch CI to macos
- Add native targets
- Update Gradle to 8.2.1
- Update kotlin to 1.9.0
- Update kotlinx.serialization to 1.6.0-RC
- Update kotlinpoet to 1.14.2
@DRSchlaubi DRSchlaubi changed the title Feature/mpp Add support for Kotlin/JS and Kotlin/Native Mar 1, 2024
@DRSchlaubi
Update Gradle to 8.6
f90d7e4
@DRSchlaubi
Update dependencies
300ea05 
- Update kotlinx-serialization-json to 1.6.3
- Update kotlin to 1.9.22
@DRSchlaubi
Update emojis.json file to reflect unicode changes
150d7a4
@DRSchlaubi
Migrate CI to Teamcity
f5c7768
@DRSchlaubi
Migrate Generator.kt to use codegen.kt
68e2a78
@DRSchlaubi
Add nextPlannedVersion
2eee481
@DRSchlaubi
Fix Native build
63101b0
@DRSchlaubi
Fix publication
3a41433
@DRSchlaubi
Fix test runs
c59086b
@DRSchlaubi
Improvements
ff60427 
- Only add one accessor per emoji instead of alias
- Add DiscordEmoji.findByName and DiscordEmoji.findByUnicode
- Add support for hair styles
- Deprecate Emojis.get
- Make Emojis.all a list
@DRSchlaubi
Fix publishing
4e0ae48
@DRSchlaubi
Enable signing
5d28c58
@DRSchlaubi DRSchlaubi mentioned this pull request Mar 15, 2024
Open
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukellmann lukellmann lukellmann left review comments

@HopeBaron HopeBaron Awaiting requested review from HopeBaron

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DRSchlaubi @lukellmann