Bugfix model #17
Open
Bugfix model #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pgrund Could you please remove code styling changes in |
|
And could you also please add some tests for that change? |
|
sorry, summer break ... will continue on this topic latest next week ... |
added 2 commits
July 30, 2021 13:42
lib/helpers/generateFilterType.ts
Outdated
| @@ -24,7 +24,8 @@ export const createFilterType = (type: Function) => { | |||
| const typeGraphQLMetadata = getTypeGraphQLMetadataStorage(); | |||
|
|
|||
| const objectTypesList = typeGraphQLMetadata.objectTypes; | |||
| const graphQLModel = objectTypesList.find((ot) => types.includes(ot.target) && (typeGraphQLMetadata.inputTypes.findIndex(it => it.name === (ot.name + "Filter")) < 0)) | |||
| const graphQLModels = objectTypesList.filter((ot) => types.includes(ot.target) && (typeGraphQLMetadata.inputTypes.findIndex(it => it.name === (ot.name + "Filter")) < 0)); | |||
| const graphQLModel = graphQLModels.find(m => m.name === type.name) || graphQLModels.slice(-1).pop() | |||
There was a problem hiding this comment.
Although, it's not critical in this particular case, but it would be better to use graphQLModels[graphQLModels.length - 1] to get last value of array instead of graphQLModels.slice(-1).pop() (to avoid redundant copying of an array)
There was a problem hiding this comment.
nice catch .. leftover from some intermediate steps ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
finding correct graphqlmodel, if not there take "closest" parent (inheritance)