Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Add initial implementation of greedy meshing algorithm #4

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

[WIP] Add initial implementation of greedy meshing algorithm #4

wants to merge 5 commits into from

Conversation

petterarvidsson
Copy link
Member

  • Implement greedy meshing algorithm
  • Add test cases

@petterarvidsson
Copy link
Member Author

@nsg I managed to fix the last bug, see last commit!

@petterarvidsson
Copy link
Member Author

Well tests still doesn't pass, but it now looks pretty :-P

nsg
nsg reviewed Jan 8, 2018
View reviewed changes
libchunkrender/chunkrender.c Outdated
@@ -259,7 +259,7 @@ void generate_rectangles(uint8_t face,
}
}

a += (width + 1);
a += width;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

@nsg
Copy link
Member

nsg commented Jan 8, 2018

Is it ready for review? or do you like to fix the tests? If you like me to review it remove WIP so we do not forget to remove it, again :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nsg nsg nsg left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@petterarvidsson @nsg