Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test remove graphics features #61

Merged
merged 1 commit into from Jul 30, 2015

Conversation

petterarvidsson
Copy link
Member

No description provided.

@petterarvidsson
Copy link
Member Author

@nsg This updates the client to work with three dimensional chunks sent by the server. Also fixes some lagging issues related to computing chunks on the main thread.

@nsg
Copy link
Member

nsg commented Jul 30, 2015

@petterarvidsson this do wonders with the lag spikes, 60fps and no lag what so ever when I tested against the reference world. Noticed no difference with the world render, that is a good thing consider this huge rewrite. Looks good, just one thought, maybe add a reminder/issue to remind us to fix the hardcoded height value.

@petterarvidsson
Copy link
Member Author

@nsg I think we should add an issue for that in the server. The client needs to interpolate the collision detection to have a smooth experience, but the heigh at which a badly placed player should be moved to should be the servers job. The server also needs to make sure that a player is not anywhere they shouldn't be. konstructs/server#63

@nsg
Copy link
Member

nsg commented Jul 30, 2015

@petterarvidsson agree

- Use 3d chunks as they come from the server
- Render the chunk from 0,0,0 and translate in shader
- Use the chunk data as it is rather than unpacked to a map
- Remove limitations that prevents blocks y < 0 to be rendered properly
petterarvidsson added a commit that referenced this pull request Jul 30, 2015
@petterarvidsson petterarvidsson merged commit 7c9375a into master Jul 30, 2015
@petterarvidsson petterarvidsson deleted the test-remove-graphics-features branch July 30, 2015 13:34
nsg added a commit that referenced this pull request Jul 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants