feat(RHTAPREL-253): queue Releases #366
Conversation
davidmogar
force-pushed
the
rhtaprel253
branch
2 times, most recently
from
999a37d
to
90da749
Compare
|
Signed-off-by: David Moreno García <damoreno@redhat.com>
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #366 +/- ##
==========================================
- Coverage 84.60% 83.55% -1.06%
==========================================
Files 26 26
Lines 1384 1423 +39
==========================================
+ Hits 1171 1189 +18
- Misses 153 172 +19
- Partials 60 62 +2 ☔ View full report in Codecov by Sentry. |
| @@ -44,6 +45,35 @@ func NewLoader() ObjectLoader { | |||
| return &loader{} | |||
| } | |||
|
|
|||
| // GetActiveManagedReleasePipelineRuns returns all active managed Release PipelineRuns for the Application being Released. | |||
| // PipelineRuns for the Release passed as an argument are ignored. | |||
| func (l *loader) GetActiveManagedReleasePipelineRuns(ctx context.Context, cli client.Client, release *v1alpha1.Release) (*tektonv1.PipelineRunList, error) { | |||
There was a problem hiding this comment.
Can we use unfinished or something instead of active? We already have active for the RP/RPA stuff
| } | ||
| return controller.RequeueAfter(time.Minute, nil) | ||
| } | ||
|
|
||
| pipelineRun, err := a.loader.GetManagedReleasePipelineRun(a.ctx, a.client, a.release) |
There was a problem hiding this comment.
Won't pipelineRuns.length be 1 if there is already a pipelineRun running for this release? So we don't have to fetch it again?
No description provided.