fix(RHTAPREL-278): add copyright to match_conditions.go #322
Conversation
jinqi7
requested review from
a team,
theflockers,
ralphbean,
davidmogar,
johnbieren,
cuipinghuo,
happybhati and
Troy876
and removed request for
a team
|
/retest |
api/v1alpha1/match_conditions.go
Outdated
| @@ -1,3 +1,19 @@ | |||
| /* | |||
| Copyright 2022. | |||
There was a problem hiding this comment.
Thanks. I am using the PR for testing the PR in e2e-tests.
jinqi7
force-pushed
the
RP_RPA_reconcile
branch
2 times, most recently
from
7a93140
to
b09867d
Compare
There was a problem hiding this comment.
The right copyright notice to use is the following one:
/*
Copyright 2023 Red Hat Inc.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
Probably we have to update other notices as well to include the company.
|
|
/retest |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #322 +/- ##
==========================================
+ Coverage 84.58% 84.65% +0.07%
==========================================
Files 29 26 -3
Lines 1654 1382 -272
==========================================
- Hits 1399 1170 -229
+ Misses 175 152 -23
+ Partials 80 60 -20 ☔ View full report in Codecov by Sentry. |
jinqi7
force-pushed
the
RP_RPA_reconcile
branch
from
ff054af
to
d66ab7c
Compare
|
|
New changes are detected. LGTM label has been removed. |
jinqi7
force-pushed
the
RP_RPA_reconcile
branch
2 times, most recently
from
ff8c941
to
c6c6311
Compare
|
/retest |
jinqi7
force-pushed
the
RP_RPA_reconcile
branch
from
c6c6311
to
5708596
Compare
|
@jinqi7 what is this PR for? It seems one day it is adding a copyright like the title says, and the next it is adding thousands of lines of change. And it keeps switching between those two |
Service logs were being cluttered whenever the ReleasePlan was created before the Application. With this change, the error when trying to find the Application is ignored and the ReleasePlan is set to be reconciled after a minute. Signed-off-by: David Moreno García <damoreno@redhat.com>
jinqi7
force-pushed
the
RP_RPA_reconcile
branch
from
e47185b
to
f869f17
Compare
|
|
@jinqi7: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
For debugging CI issue...