Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox media keys #1236

Open
joshuamooree opened this issue Jul 17, 2020 · 3 comments · May be fixed by koel/docs#20
Open

Firefox media keys #1236

joshuamooree opened this issue Jul 17, 2020 · 3 comments · May be fixed by koel/docs#20

Comments

@joshuamooree
Copy link

Firefox now supports media keys (right now has to be enabled in about:config): https://www.ghacks.net/2020/03/23/firefox-will-soon-support-hardware-media-controls/ . As long as media.hardwaremediakeys.enabled and dom.media.mediasession.enabled are set to true, this feature now works in Firefox with no changes to Koel (tested with 78.0.2 on Windows 10). You should mention this in the documentation.

@BrookeDot
Copy link
Member

I had no idea that Firefox added Media Control support, pretty cool! I looked into this and as of Firefox 81 these are enabled by default:
https://support.mozilla.org/en-US/kb/control-audio-or-video-playback-your-keyboard

The docs currently say:

On a modern Chromium-based browser, you can control Koel using hardware media keys without even having Koel or the browser focused.

It sounds like this extended to Firefox now too, but if we are going to update the docs, we should check if we can say on "modern browsers", thus including Safari, Brave, etc. Or if things should be written specifically to Firefox and Chromium-based browsers.

Once that's been determined, a PR can be made on the docs site:
https://github.com/koel/docs/blob/master/src/README.md#using-the-web-interface

@phanan
Copy link
Member

phanan commented Dec 31, 2020

Isn't it now a norm on macOS? I don't own a Windows anymore (since like forever), so I can't really confirm this.

BrookeDot added a commit to koel/docs that referenced this issue Jan 1, 2021
@BrookeDot BrookeDot linked a pull request Jan 1, 2021 that will close this issue
@BrookeDot
Copy link
Member

I did some testing on macOS 11 with Safari 13 and didn't work as smoothly as in Chromium or Firefox. I decided to make a PR leaving out Safari for now, it may work but this is at least an improvement.

koel/docs#20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants