fix: Well formated descriptions is not visible

[Jarsen136]

Thank you for your contribution to the Koda - Generative Art Marketplace.

👇 __ Let's make a quick check before the contribution.

PR Type

• Bugfix

Needs QA check

• @kodadot/qa-guild please review

Context

• Closes Well formated descriptions is not visible #10291
• Closes Base collections on Koda: missing description #10279

Did your issue had any of the "$" label on it?

• My DOT address: Payout

Screenshot 📸

• My fix has changed something on UI; a screenshot is best to understand changes for others.

[netlify]

✅ Deploy Preview for koda-canary ready!

Name	Link
🔨 Latest commit	dbbefa2
🔍 Latest deploy log	https://app.netlify.com/sites/koda-canary/deploys/66467777d29b120008c9ef96
😎 Deploy Preview	https://deploy-preview-10292--koda-canary.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[JustLuuuu]

Can we please also get a release before the drop? So description is not missing?

[Jarsen136]

Can we please also get a release before the drop? So description is not missing?

Sure yes

[hassnian]

as a quick fix code LGTM

what's the reason of metadata being defined and meta being null ?

[Jarsen136]

but can't we fix this on the indexer side what's the reason of metadata being defined and meta being null ?

I'm not sure. Is it possible to fix this case also on the indexer side? @vikiival

[vikiival]

Already fixed

[vikiival]

what's the reason of metadata being defined and meta being null ?

Very slow image worker
cc @preschian

[Jarsen136]

Already fixed

Just FYI, this PR also fixed the missing meta issue on base chain. #10279

https://deploy-preview-10292--koda-canary.netlify.app/base/collection/0x3c93690bbe585475fdfadab3f59b4604008c7ac4

[preschian]

what's the reason of metadata being defined and meta being null ?

Very slow image worker cc @preschian

In this case, I think it's better to fix it on the indexer side. Retry the fetch on this one metadata being defined and meta being null. Add max retry or at least increase timeout.

Because it's expected to be slow at the first request, fxhash has good documentation about the downside of IPFS: https://docs.fxhash.xyz/decentralised-storage-ipfs-and-onchfs#7f156ce9fbbd4b239de17e7e418b27d5. It's recommended to read about why it's slow.

FYI, the reason image workers exist is to speed up that downside. On the second request, it should be faster.

[codeclimate]

Code Climate has analyzed commit dbbefa2 and detected 0 issues on this pull request.

View more on Code Climate.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[Jarsen136]

what's the reason of metadata being defined and meta being null ?

Very slow image worker cc @preschian

In this case, I think it's better to fix it on the indexer side. Retry the fetch on this one metadata being defined and meta being null. Add max retry or at least increase timeout.

Because it's expected to be slow at the first request, fxhash has good documentation about the downside of IPFS: https://docs.fxhash.xyz/decentralised-storage-ipfs-and-onchfs#7f156ce9fbbd4b239de17e7e418b27d5. It's recommended to read about why it's slow.

FYI, the reason image workers exist is to speed up that downside. On the second request, it should be faster.

After adding retry logic, can we guarantee that every collection will have meta data returned?
I suggest merging the current PR to fix all related issues first. And then we gradually fix the missing meta issues one by one on the indexer side.
We could do both of the two solutions.
wdyt?
@vikiival @preschian

[preschian]

I suggest merging the current PR to fix all related issues first

yes, please

[preschian]

After adding retry logic, can we guarantee that every collection will have meta data returned?

If the problem is because of timeout while fetching the ipfs gateway, it should be fixed with that