Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Change the NeoButton style that so that button style is disable… #10277

Closed

Conversation

Victor0355
Copy link

@Victor0355 Victor0355 commented May 12, 2024

Thank you for your contribution to the Koda - Generative Art Marketplace.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix

Needs Design check

Needs QA check

  • @kodadot/qa-guild please review

Context

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

  • This is the style before change.
    image

  • This is the style after change.
    image

@Victor0355 Victor0355 requested a review from a team as a code owner May 12, 2024 03:33
@Victor0355 Victor0355 requested review from daiagi and hassnian and removed request for a team May 12, 2024 03:33
Copy link

netlify bot commented May 12, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit f7dd57b
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/6644766d022c94000816104f
😎 Deploy Preview https://deploy-preview-10277--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vikiival
Copy link
Member

vikiival commented May 13, 2024

cc @daiagi @hassnian

Copy link
Contributor

@hassnian hassnian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing #10210 (comment)

CleanShot 2024-05-13 at 17 48 09

@exezbcz visual check , thanks

@prury prury added the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label May 13, 2024
Copy link

codeclimate bot commented May 15, 2024

Code Climate has analyzed commit f7dd57b and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

sonarcloud bot commented May 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Victor0355 Victor0355 requested a review from hassnian May 15, 2024 09:12
@Victor0355
Copy link
Author

Victor0355 commented May 17, 2024

Hi @hassnian ,
I'd like you to check my new commit as soon as possible.

image

I've updated to the button effect according to your request.

image

@prury
Copy link
Member

prury commented May 17, 2024

Contribution does not match our code standards:

  • too much duplicated code and failing to solve the issue

@prury prury closed this May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-changes-requested-🤞 PR is almost good to go, just some fine tunning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Button states (active, focus) - revisions
4 participants