Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Paid mint modal auto-teleport flow #10258

Merged
merged 8 commits into from
May 20, 2024
Merged

Conversation

hassnian
Copy link
Contributor

@hassnian hassnian commented May 7, 2024

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

option 2 , have always one, once auto-teleport modal is open the below one is gone and once the teleport is done the other one appears with the success step

  1. paid mint auto-teleport flow changed (only one modal at a time)
  2. fix: minting session getting cleared on mint cancel when doing teleport

@prury pls test theses 3 flows

  • normal flow
  • autoteleport flow
  • mutiple autotelport in one session

I've attached bellow videos for each one , thanks

Needs QA check

  • @kodadot/qa-guild please review

Needs Design check

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Screenshot 📸

  • My fix has changed something on UI;

paid mint auto teleport

CleanShot.2024-05-07.at.16.04.58.mp4

paid mint normal flow

CleanShot.2024-05-07.at.17.05.32.mp4

testing multiple autotelport in one session

CleanShot.2024-05-08.at.16.59.18.mp4

Copy link

netlify bot commented May 7, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 65a7c3d
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/664b4fc82707d10008edf588
😎 Deploy Preview https://deploy-preview-10258--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hassnian hassnian marked this pull request as ready for review May 8, 2024 12:30
@hassnian hassnian requested a review from a team as a code owner May 8, 2024 12:30
@hassnian hassnian requested review from vikiival and daiagi and removed request for a team May 8, 2024 12:30
@hassnian hassnian changed the title fix: Paid mint modal autotelport flow fix: Paid mint modal auto-teleport flow May 8, 2024
@prury
Copy link
Member

prury commented May 8, 2024

i was testing and normal flow went ok, but then i started facing issues with auto-teleport that we are solving in #10264 , let's wait for it to be merged. So far one modal at time was working ok

@hassnian
Copy link
Contributor Author

hassnian commented May 9, 2024

i was testing and normal flow went ok, but then i started facing issues with auto-teleport that we are solving in #10264 , let's wait for it to be merged. So far one modal at time was working ok

What drop are you using to do the tests ? I tested it with meadow and worked fine , didn't face that issue once

#10264 it's only happening with hdd drop isn't ?

These two issue are not related , and should be able to be solved independently , but we can wait.

Is the balance check issue also happening in other drops ?

@prury
Copy link
Member

prury commented May 9, 2024

These two issue are not related , and should be able to be solved independently , but we can wait.

Is the balance check issue also happening in other drops ?

sorry for the lack of info, but yes, it also happened on meadow.

@vikiival
Copy link
Member

cc @daiagi

@vikiival
Copy link
Member

cc @prury ?

Copy link

codeclimate bot commented May 16, 2024

Code Climate has analyzed commit 09fc737 and detected 0 issues on this pull request.

View more on Code Climate.

@prury
Copy link
Member

prury commented May 16, 2024

cc @prury ?

i was OOO
but now i can test this one properly as the other two PRs needed have been merged

@prury
Copy link
Member

prury commented May 16, 2024

@hassnian i think we are good, only thing i was found uncommon was loading modal between some steps(1:56), but its coming from canary, so.

overlapping modals seems to be solved, and modals seems to be appearing in right places at the right time.
no closing when transaction is cancelled

whole autoteleport + autoteleport process:

Gravacao.de.tela.de.16-05-2024.10.25.55.webm

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label May 16, 2024
@vikiival
Copy link
Member

@JustLuuuu can u please check?

@JustLuuuu
Copy link
Member

I think its ok

Copy link

sonarcloud bot commented May 20, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@vikiival vikiival added this pull request to the merge queue May 20, 2024
Merged via the queue into kodadot:main with commit 795603c May 20, 2024
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Paid mint modal closes if transaction errors while auto teleporting
5 participants