feat: Preview images on /code-checker
#10240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hassnian
changed the title
/code-checker
✅ Deploy Preview for koda-canary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
|
@exezbcz I need a state for failed previews , thanks |
Jarsen136
approved these changes
May 20, 2024
daiagi
requested changes
May 20, 2024
daiagi
approved these changes
May 21, 2024
|
Code Climate has analyzed commit 716ee51 and detected 2 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
|
|
well, i get some errors sometimes when use the capturing service test, but i guess is related to the art uploaded, will keep an eye on it, merging. @preschian let's say a new art is uploaded and the capturing service is somehow not showing the images properly, what's the course of action? inform devs? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Context
❗️❗️ Needs https://github.com/kodadot/private-workers/pull/154
/code-checker#10207Needs QA check
Did your issue had any of the "$" label on it?
Screenshot 📸