Implement default selection for directories_categorySimple #817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
don't access database in constuctor |
fraxachun
approved these changes
May 7, 2018
kaufmo
approved these changes
May 8, 2018
|
@nsams added a check to the constructor. The initial problem: if creating a component and than cancel the process (without saving a value for the allowBlank(false) category-select) results in an exception on rendering the component. It's also not possible to delete the defect component or edit anything else on the site. |
|
kann der default wert nicht in der komponente gemacht werden wenn nix gespeichert ist? |
|
eigentlich wäre besser, wenn einfach eine fehlermeldung gerendert wird. den eine zufällige liste an artikel ist whs nie was man will. |
|
Ja, oder einfach gar keine artikel? |
If component throws an exception it's not possible to delete this in backend anymore or edit any other component in same paragraphs component. If component shows random articles superuser might not realise configuration is wrong so better show noting
Its's possible to cancel component creation leaving directory_component_id empty resulting in $itemDir object null. By only adding config values on existing itemDir component renders "no entries found" which should be an indicator for superuser that something is wrong.
|
hatte den selben gedanken auch gerade. Ist so angepasst. (und an einer weiteren stelle behoben) |
nsams
reviewed
May 19, 2018
| foreach ($model->getRows($s) as $row) { | ||
| $itemIds[] = $row->item_id; | ||
| } | ||
| $select->where(new Kwf_Model_Select_Expr_Boolean(false)); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as this needs a category_id to work.