converted fulltext box search js code from ext2 to jquery #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaufmo
reviewed
Sep 20, 2017
|
|
||
| var FulltextSearchBoxComponent = function(el, config) { | ||
| this.el = el; | ||
| this.config = config; | ||
|
|
||
| if (this.config.hideSubmit) { | ||
| this.el.child('.submitWrapper').enableDisplayMode(); | ||
| this.el.child('.submitWrapper').hide(); | ||
| this.el.find('.submitWrapper').hide(); |
There was a problem hiding this comment.
pls sandbox all class selectors with kwfUp- prefix
| @@ -108,7 +108,7 @@ FulltextSearchBoxComponent.prototype = | |||
| this.loadSearch({ | |||
| success: function() { | |||
| historyState.currentState.searchVisible = true; | |||
| var ajaxViewEl = this.searchMainContent.child('.kwcDirectoriesListViewAjax'); | |||
| var ajaxViewEl = this.searchMainContent.find('.kwcDirectoriesListViewAjax'); | |||
| style: 'width: ' + this.previousMainContent.getStyle('width'), | ||
|
|
||
| this.loadingContent = $('<main>', { | ||
| class: 'kwfUp-kwfMainContent loadingContent', |
MFSepplive
force-pushed
the
fulltext-search-box-with-jquery
branch
from
4cbcba1
to
cb0b5ab
Compare
kaufmo
approved these changes
Sep 20, 2017
MFSepplive
force-pushed
the
fulltext-search-box-with-jquery
branch
from
cb0b5ab
to
a3f3b7c
Compare
MFSepplive
force-pushed
the
fulltext-search-box-with-jquery
branch
from
a3f3b7c
to
8aabbcb
Compare
|
@MFSepplive das war ja komplett auskommentiert und ist es jetzt nicht mehr. bitte den PR so lassen aber zusätzlich erneut auskommentieren. Dann können wir das falls wir es re-aktivieren wollen leichter machen weil es ja schon auf jQuery konvertiert ist. |
|
@MFSepplive was tun wir damit? machst du das noch fertig oder schließen wir ihn? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.