Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update github.com/awslabs/amazon-ecr-credential-helper to latest version #1267

Merged
merged 1 commit into from Mar 26, 2024

Conversation

nesty92
Copy link
Contributor

@nesty92 nesty92 commented Mar 26, 2024

Resolves: #1245

And allow the use of OIDC

This is basically:

# git checkout main
# go get -u github.com/awslabs/amazon-ecr-credential-helper/ecr-login
# go mod tidy
# go mod vendor
# git add -A

Replacement of: #1248

…e issues with AWS ECR authentication

Signed-off-by: Ernesto Alejandro Santana Hidalgo <ernesto.alejandrosantana@gmail.com>
@imjasonh imjasonh enabled auto-merge (rebase) March 26, 2024 11:13
@imjasonh imjasonh merged commit 3a58bcd into ko-build:main Mar 26, 2024
16 of 22 checks passed
@nesty92 nesty92 deleted the fix/aws_ecr branch March 26, 2024 11:18
@renanqts
Copy link

renanqts commented Apr 8, 2024

Thanks for that.
Could you please release a version with that fix?

@nesty92
Copy link
Contributor Author

nesty92 commented Apr 8, 2024

@renanqts If you are using the latest container images they are updated

@renanqts
Copy link

renanqts commented Apr 8, 2024

yes, I'm using the binaries. It would be nice to have it there, otherwise, I will use the image

@cpanato
Copy link
Member

cpanato commented Apr 8, 2024

will review and see if there are other things to be released as well

@renanqts
Copy link

renanqts commented Apr 8, 2024

will review and see if there are other things to be released as well

thanks a lot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pushing to ECR without logging in first doesn't work
4 participants