Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update awslabs/amazon-ecr-credential-helper to latest #1248

Closed
wants to merge 2 commits into from
Closed

Update awslabs/amazon-ecr-credential-helper to latest #1248

wants to merge 2 commits into from

Commits on Mar 5, 2024

  1. Update awslabs/amazon-ecr-credential-helper to latest 

    This update fixes an apparent conflict between the
amazon-ecr-credential-helper library and the aws-sdk-go-v2 library,
introduced when aws-sdk-go-v2 was updated as a byproduct of a cosign
upgrade in #1191.

This mismatch resulted in an error:
"ecr: Failed to get authorization token: not found, ResolveEndpointV2"

However, this error was not readily apparent due to overridding the
ecr-login module's logger to io.Discard in pkg/commands/config.go.

Resolves: #1245
Signed-off-by: Eric Searcy <eric@linuxfoundation.org>
    @emsearcy
    emsearcy committed Mar 5, 2024
    Copy the full SHA
    e5012a5 View commit details
    Browse the repository at this point in the history

  2. Tidy mod.sum 

    Result of running ./hack/update-codegen.sh

Signed-off-by: Eric Searcy <eric@linuxfoundation.org>
    @emsearcy
    emsearcy committed Mar 5, 2024
    Copy the full SHA
    98c1b1a View commit details
    Browse the repository at this point in the history