Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Klicky Probe #461

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Klicky Probe #461

wants to merge 2 commits into from

Conversation

sui77
Copy link

@sui77 sui77 commented May 25, 2023

Description

Enables the use of a DIY magnetic mounted (aka "klicky") probe. It basically already works (preview video) but is still a work in progress. I need to refine STLs that I intend to publish on printables, write instructions and fine tune deploy&stow movements. I'd prefer to link to this well known repository instead of maintaining a fork, so if this comes into question I kindly ask you to do a first quick review before I go on.

Requirements

A klicky probe that consists of 4x1mm magnets, a limit switch and these STLs https://github.com/sui77/3d-printing/tree/master/klicky/stl that fit on a [MK4] carriage. Wiring is same as BLTOUCH except it doesn't utilize a servo.

Configurations

At this point I've added these environments: MEGA_TMC_KLICKY and MEGA_S_TMC_KLICKY

@knutwurst knutwurst self-assigned this May 25, 2023
@knutwurst knutwurst added the new feature New feature or request label May 25, 2023
@knutwurst
Copy link
Owner

I like the idea and your implementation looks very solid. Glad you followed the guidelines and added a new build environment. :)

However, I see some minor problems here:

  1. So far I don't know anyone who uses this kind of probe except you.
  2. The two new environments are only available for the Mega and Mega S with TMC drivers, but no other combinations (without TMC or Mega Pro, Mega X etc).
  3. I'm trying not to include any more configurations for the supported printers as we're already on a release of 50 assets.

My suggestion:
You waive the environments for the Mega and Mega S, but only adopt the new KNUTWURST_CLICKY build flag. Then you can easily add the functionality if you compile the firmware yourself. Only finished binaries will not exist then.

I understand your intention to always get the firmware for your printer from this source, but I'm afraid that in this absolute special case a fork is the better choice.

@knutwurst knutwurst assigned sui77 and unassigned knutwurst Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants