Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improving image sizes #39

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

improving image sizes #39

wants to merge 1 commit into from

Conversation

Leannapelham
Copy link
Member

ran all the blog images through an optimizer to improve image size

Copy link
Contributor

@MolloKhan MolloKhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

@weaverryan
Copy link
Member

These images are processed through Imagine and thumnailed. So the source image is not what we show the user. So I'm genuinely not sure if this affects the final image sizes or not. @Leannapelham were you generally being proactive or did you see a problem with the image sizes on the site?

@bocharsky-bw
Copy link
Member

Hm, yeah, not sure if updated source image size will affect the final image size after Imagine.

Btw, Lighthouse (IIRC) suggests using the new Webp format for images as that one has even better size with the same quality. And I see Imagine in theory should support it as well: https://github.com/liip/LiipImagineBundle/blob/2.x/Resources/doc/basic-usage.rst#webp-image-format

I wonder if we should move to that format instead?

@weaverryan
Copy link
Member

Hmm, what about 2 things:

  1. See if we can use liip to change to webp, since it's better.
  2. Stop using cloudfront entirely to store the images. Instead, store them locally on p.sh. We would probably need to set up a mount for the public dir where the final imagine image files would be stored. But then, done. Cloudflare already caches these. And we could even enable polish to optimize them a bit further.

@bocharsky-bw
Copy link
Member

That would simplify things with blog... I think we kinda overcomplicated it now. I wonder if we should add hash to the image filenames to allow us to cache them forever?

Also wonder if that Polish (🇵🇱?) thing would require to be paid extra.

@MolloKhan
Copy link
Contributor

That would simplify things with blog... I think we kinda overcomplicated it now. I wonder if we should add hash to the image filenames to allow us to cache them forever?

Also wonder if that Polish (🇵🇱?) thing would require to be paid extra.

I think we're pro
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants