Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #52 #53

Merged
merged 2 commits into from
Sep 27, 2016
Merged

Fixes #52 #53

merged 2 commits into from
Sep 27, 2016

Conversation

aklkv
Copy link

@aklkv aklkv commented Sep 15, 2016

No description provided.

@aklkv
Copy link
Author

aklkv commented Sep 27, 2016

@knownasilya test are failing due to this issue: emberjs/ember.js#13948
I am not sure what I can do to fix it, it looks like more fundamental change needs to be done to fix it

knownasilya
knownasilya approved these changes Sep 27, 2016
View reviewed changes
Copy link
Owner

@knownasilya knownasilya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@knownasilya knownasilya merged commit 31a99a8 into knownasilya:master Sep 27, 2016
knownasilya pushed a commit that referenced this pull request Oct 25, 2016
v2.0.2
0e7b980 
- docs: Add instructions for installation, see #47
- fix(docs): change on/offValue to on/offLabel, see #50
- fix(tests): Add ember-alpha
- fix(deprecation): Replace `contains` with `includes`, see #53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knownasilya knownasilya knownasilya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aklkv @knownasilya