Updated sqlite3 and better-sqlite3 to use more accurate numeric types #6063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check this for more context on what the PR does #5789 (comment) |
rluvaton
reviewed
Apr 23, 2024
There was a problem hiding this comment.
It would be breaking change even though it's correct, @kibertoad WDYT?
rluvaton
reviewed
Apr 23, 2024
| @@ -755,6 +755,7 @@ describe('BetterSQLite3 SchemaBuilder', function () { | |||
| equal(tableSql[0].sql, 'alter table `users` add column `foo` float'); | |||
| }); | |||
|
|
|||
|
|
|||
There are two folders |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing
sqlite3andbetter-sqlite3numeric types. When trying to useknex.decimal()orknex.double()with sqlite3 it turns them tofloat. Issue #5789