Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: clean old CI versions & exceptions #6047

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Chore: clean old CI versions & exceptions #6047

wants to merge 3 commits into from
+3 −7

Conversation

stscoundrel
Copy link
Contributor

There were some leftovers from when Node 20 was added to CI and 12/14 were dropped.

  • Remove Node 12 specific dependency install. It is not used anymore.
  • Run individual one-version-only Node 16 and Node 18 tasks in latest LTS (=20). They were the odd ones out.
  • Update supported Node versions in readme. It suggested everything from 12 onwards were still supported.

@coveralls
Copy link

Coverage Status

coverage: 92.842%. remained the same
when pulling ea31d98 on stscoundrel:chore/clean-old-ci-versions
into aedba5e on knex:master.

@stscoundrel
Copy link
Contributor Author

What do you think @kibertoad ? Seems the failed CI runs are unrelated to this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stscoundrel @coveralls