Disable propagateCreateError by default

[guerrerocarlos]

The attribute propagateCreateError should be set to false by default to prevent unexpected Timeout acquiring a connection. The pool is probably full. Are you missing a .transacting(trx) call? error.

Explanation:

The propagateCreateError is set to true by default in Knex and throws a TimeoutError if the first create connection to the database fails, preventing tarn (the connection pool manager) from re-connecting automatically.

The solution is to set propagateCreateError to false thus enabling knex to automatically reconnect on create connection failure, instead of throwing the error, and only throwing it when the acquireTimeoutMillis has passed, as defined by tarn

Related issues:

#1381 #1382 #1655 #2445 strapi/strapi#2790 #1875 #1909 #2302 #2141 #1264

[elhigu]

Propagating the error is the correct and intentional functionality. If you think there is a problem, please add bug report with reproduction case.

If that error is coming before acquireTimeoutMillis has passed, then problem is elsewhere.

That propagateCreateError parameter was originally added to tarn, because I needed it for knex to be able to get errors immediately if there is connection error to the database.

Acquire timeout is waited only in that case if pool is full and we need to wait for free connection slots.