Rewrite code #119
Draft
Rewrite code #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kneasle
added a commit
that referenced
this pull request
Sep 29, 2021
This was causing #119 to falsely fail the PR tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite of Sapling's initial prototype. The main change is that ASTs are now stored as concrete trees (i.e. trees of formatted tokens) specified by dynamically loaded
Grammars. This means that, whilst the representation isn't text-based, the original formatted text version of any tree can be unambiguously reconstructed.This is currently very WIP (I'm mostly writing this bottom-up, so there's no UI yet). This is mostly because the current tree-manipulation architecture makes ASTs really painful to create without a parsing engine, so I'm making a basic parser before starting on the rest of the editor.