Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Automated] Update net-contour nightly #15204

Merged

Conversation

knative-automation
Copy link
Contributor

@knative-automation knative-automation commented May 14, 2024

/assign @knative/serving-writers
/cc @knative/serving-writers

Produced via:

for x in net-contour.yaml contour.yaml; do
  curl https://storage.googleapis.com/knative-nightly/net-contour/latest/$x > ${GITHUB_WORKSPACE}/./third_party/contour-latest/$x
done

Details:

bumping knative.dev/net-contour 1fd25ff...1416c53:
  > 1416c53 fix nil pointer dereference when parsing config map (# 1095)
  > 28e07b4 upgrade to latest dependencies (# 1094)
  > 6bfecbe Update actions (# 1092)
  > ebc09d7 upgrade to latest dependencies (# 1090)
  > a0f7039 Set CORS policy values only for when HTTPProxy associated with external visibility (# 1088)
  > 2f25f7a upgrade to latest dependencies (# 1087)

Copy link

knative-prow bot commented May 14, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: knative-automation
Once this PR has been reviewed and has the lgtm label, please assign retocode for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 14, 2024
Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.73%. Comparing base (60c003b) to head (e7619c8).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #15204   +/-   ##
=======================================
  Coverage   84.73%   84.73%           
=======================================
  Files         218      218           
  Lines       13473    13473           
=======================================
+ Hits        11416    11417    +1     
  Misses       1688     1688           
+ Partials      369      368    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ReToCode
Copy link
Member

/test contour-latest

1 similar comment
@ReToCode
Copy link
Member

/test contour-latest

@ReToCode
Copy link
Member

Three tries did not help, cc @izabelacg @dprotaso

@knative-automation knative-automation force-pushed the update-nightly/net-contour branch 2 times, most recently from f6dc3ce to f71cbdb Compare May 16, 2024 11:05
@dprotaso
Copy link
Member

/retest

bumping knative.dev/net-contour 1fd25ff...1416c53:
  > 1416c53 fix nil pointer dereference when parsing config map (# 1095)
  > 28e07b4 upgrade to latest dependencies (# 1094)
  > 6bfecbe Update actions (# 1092)
  > ebc09d7 upgrade to latest dependencies (# 1090)
  > a0f7039 Set CORS policy values only for when HTTPProxy associated with external visibility (# 1088)
  > 2f25f7a upgrade to latest dependencies (# 1087)

Signed-off-by: Knative Automation <automation@knative.team>
@dprotaso
Copy link
Member

Blocked on #15235

@dprotaso
Copy link
Member

/retest

@dprotaso
Copy link
Member

/retest

TestControllerHA flake

@dprotaso
Copy link
Member

oh nm it's still running

@knative-prow knative-prow bot merged commit e42ed25 into knative:main May 23, 2024
66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files. skip-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants