Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use deprecated func NewConfigFromConfigMap in deprecated_config.go #13847

Closed
wants to merge 1 commit into from

Conversation

nak3
Copy link
Contributor

@nak3 nak3 commented Apr 5, 2023

Although NewConfigFromConfigMap is not marked, it is a function in deprecated_config.go.
knative/networking#787 is making as deprecated.

This patch changes to use a func in knative.dev/networking/pkg/config, instead.

/cc @dprotaso

@knative-prow knative-prow bot requested a review from dprotaso April 5, 2023 05:44
@knative-prow
Copy link

knative-prow bot commented Apr 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nak3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/autoscale area/networking labels Apr 5, 2023
@nak3
Copy link
Contributor Author

nak3 commented Apr 5, 2023

xref: knative/networking#787

@codecov
Copy link

codecov bot commented Apr 5, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.09 ⚠️

Comparison is base (dab78d1) 86.33% compared to head (612ff9b) 86.25%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13847      +/-   ##
==========================================
- Coverage   86.33%   86.25%   -0.09%     
==========================================
  Files         198      198              
  Lines       14669    14669              
==========================================
- Hits        12665    12653      -12     
- Misses       1708     1716       +8     
- Partials      296      300       +4     
Impacted Files Coverage Δ
cmd/activator/main.go 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nak3
Copy link
Contributor Author

nak3 commented Apr 5, 2023

/hold

There are other places where use the NewConfigFromConfigMap(). Probably it is better to add NewConfigFromConfigMap in networking/pkg/config.

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 5, 2023
@nak3
Copy link
Contributor Author

nak3 commented Apr 6, 2023

Closing as per knative/networking#787 (comment)

@nak3 nak3 closed this Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers area/autoscale area/networking do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant