Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move tests from net-certmanager to serving #398

Merged
merged 2 commits into from May 21, 2024

Conversation

skonto
Copy link
Contributor

@skonto skonto commented Apr 4, 2024

Which issue(s) this PR fixes:

Copy link

knative-prow bot commented Apr 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot requested review from krsna-m and mgencur April 4, 2024 12:44
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 4, 2024
@skonto skonto changed the title move tests from net-certmanager to serving Move tests from net-certmanager to serving Apr 4, 2024
@skonto skonto requested review from dprotaso and ReToCode and removed request for mgencur and krsna-m April 4, 2024 12:45
@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 4, 2024
Copy link
Member

@ReToCode ReToCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The Serving PR needs to be in first, right?

@dprotaso
Copy link
Member

/hold

release is next week and the serving PR hasn't merged. We'll want to revisit this after the release

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 17, 2024
@dprotaso
Copy link
Member

/hold cancel

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 21, 2024
@dprotaso
Copy link
Member

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 21, 2024
@knative-prow knative-prow bot merged commit 0e8c561 into knative:main May 21, 2024
18 checks passed
Copy link

knative-prow bot commented May 21, 2024

@skonto: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key serving-main.gen.yaml using file prow/jobs/generated/knative/serving-main.gen.yaml

In response to this:

Which issue(s) this PR fixes:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants