Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pkger runs only when necessary #449

Merged
merged 1 commit into from
Jul 30, 2021

Commits on Jul 30, 2021

  1. fix: unnecessary template repackaging

    Removes python caches on template test.  This appears to be the original
    cause of unnecessary rebuilds.
    
    Adds pkger.go as an explict entry in the CODE prerequisite var.  This
    ensures pkged.go is generated if it doesn't exist, and removes the need
    to explicitly enumerate it as a prerequisite to other targets.
    
    Adds pkger.go to the clean target.  This allows a 'make clean && make' to
    work as one might expect.  For example ensuring a rebuild if a template
    files is removed.
    
    The notable conceptual change here is that this does not induce a build of
    pkged.go by explicitly enumarating it as a prerequisite (a difficult
    thing to get right, and prone to errors in the future), but rather
    directly enumerates ./templates as its prerequisite.
    
    Additional minor modifications include:
    - regenerated pkged.go such that this takes effect for main on merge
    - adds an explicit target for the 'func' binary and aliases 'build'
    - Makefile help text cleanup and consolidation
    lkingland committed Jul 30, 2021
    Configuration menu
    Copy the full SHA
    461a339 View commit details
    Browse the repository at this point in the history