chore: upload coverage of unittests together #2301
Conversation
Before this each run for respective OS carried out upload to codecov server however this consumes codecov tokenless upload limit. Signed-off-by: Matej Vašek <mvasek@redhat.com>
knative-prow
bot
added
the
size/S
knative-prow
bot
added
the
approved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2301 +/- ##
==========================================
+ Coverage 60.53% 64.76% +4.22%
==========================================
Files 127 127
Lines 14779 11476 -3303
==========================================
- Hits 8946 7432 -1514
+ Misses 4933 3145 -1788
+ Partials 900 899 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
matejvasek
requested review from
dsimansk,
gauron99 and
lkingland
and removed request for
maximilien and
vyasgun
|
PTAL @dsimansk |
Signed-off-by: Matej Vašek <mvasek@redhat.com>
|
@matejvasek wrt/ Codecov ~6% drop. Isn't unified uploader missing some reports? Update, actually it's stated in the dashboard. Hence different count of reports shouldn't be a problem, if we have same content, right? |
Yes, there should be less reports since three reports were merged into one. I have no idea why the coverage decreased. |
Strangely, it reports head 14 uploads vs. now 6 uploads. It's really off. |
I would not expect that this would be needed for codecov upload. Signed-off-by: Matej Vašek <mvasek@redhat.com>
| name: "Upload coverage" | ||
| runs-on: "ubuntu-latest" | ||
| steps: | ||
| - uses: actions/checkout@v4 |
There was a problem hiding this comment.
@matejvasek really surprising find. :)
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dsimansk, matejvasek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Upload results of unit tests on various operating systems at once as opposed to uploading them individually.