Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: call appropriate script in CI GH action #2297

Merged
merged 4 commits into from
May 13, 2024

Conversation

matejvasek
Copy link
Contributor

No description provided.

Signed-off-by: Matej Vašek <mvasek@redhat.com>
@matejvasek matejvasek requested a review from dsimansk May 13, 2024 09:20
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 13, 2024
@matejvasek matejvasek requested review from gauron99 and removed request for nainaz May 13, 2024 09:21
@dsimansk
Copy link
Contributor

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 13, 2024
Copy link

knative-prow bot commented May 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [dsimansk,matejvasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Matej Vašek <mvasek@redhat.com>
Signed-off-by: Matej Vašek <mvasek@redhat.com>
Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.31%. Comparing base (b97d841) to head (ea46275).
Report is 81 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2297       +/-   ##
===========================================
- Coverage   64.21%   53.31%   -10.90%     
===========================================
  Files         108      126       +18     
  Lines       13918    11470     -2448     
===========================================
- Hits         8937     6115     -2822     
- Misses       4108     4599      +491     
+ Partials      873      756      -117     
Flag Coverage Δ
e2e-test ?
e2e-test-oncluster ?
e2e-test-runtime-go 26.21% <ø> (?)
integration-tests ?
unit-tests-macos-latest 47.88% <ø> (-0.97%) ⬇️
unit-tests-ubuntu-latest 48.98% <ø> (-0.61%) ⬇️
unit-tests-windows-latest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Matej Vašek <mvasek@redhat.com>
@knative-prow knative-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 13, 2024
@dsimansk
Copy link
Contributor

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 13, 2024
@dsimansk
Copy link
Contributor

/override codecov/project

Copy link

knative-prow bot commented May 13, 2024

@dsimansk: Overrode contexts on behalf of dsimansk: codecov/project

In response to this:

/override codecov/project

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot merged commit 1a17594 into knative:main May 13, 2024
34 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants