Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update paketo dep #2296

Merged
merged 1 commit into from
May 13, 2024
Merged

Conversation

matejvasek
Copy link
Contributor

@matejvasek matejvasek commented May 11, 2024

This is required to fix currently failing periodic image build.

Signed-off-by: Matej Vašek <mvasek@redhat.com>
@knative-prow knative-prow bot requested review from rhuss and vyasgun May 11, 2024 13:19
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 11, 2024
@matejvasek matejvasek requested review from matzew, jrangelramos, gauron99 and lkingland and removed request for rhuss and vyasgun May 11, 2024 13:19
Copy link

codecov bot commented May 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.71%. Comparing base (b97d841) to head (ab7cb1e).
Report is 80 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2296      +/-   ##
==========================================
- Coverage   64.21%   60.71%   -3.50%     
==========================================
  Files         108      127      +19     
  Lines       13918    14779     +861     
==========================================
+ Hits         8937     8973      +36     
- Misses       4108     4906     +798     
- Partials      873      900      +27     
Flag Coverage Δ
e2e-test 38.40% <ø> (+1.02%) ⬆️
e2e-test-oncluster 31.50% <ø> (+1.00%) ⬆️
e2e-test-oncluster-runtime 27.74% <ø> (?)
e2e-test-runtime-go 26.21% <ø> (?)
e2e-test-runtime-node 27.22% <ø> (?)
e2e-test-runtime-python 27.17% <ø> (?)
e2e-test-runtime-quarkus 27.26% <ø> (?)
e2e-test-runtime-rust 26.29% <ø> (?)
e2e-test-runtime-springboot 26.35% <ø> (?)
e2e-test-runtime-typescript 27.31% <ø> (?)
integration-tests 49.89% <ø> (+0.04%) ⬆️
unit-tests-macos-latest 47.89% <ø> (-0.95%) ⬇️
unit-tests-ubuntu-latest 48.97% <ø> (-0.63%) ⬇️
unit-tests-windows-latest 47.57% <ø> (-1.29%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 13, 2024
Copy link

knative-prow bot commented May 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matejvasek, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 6dc929c into knative:main May 13, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants