Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pin octokit npm module version to 3 #2295

Merged
merged 1 commit into from
May 13, 2024

Conversation

matejvasek
Copy link
Contributor

@matejvasek matejvasek commented May 11, 2024

The newer version of octokit (v4) uses some different module type and require() does not work nice with it.

This is required to fix currently failing periodic quarkus/sprint-boot version update.

Signed-off-by: Matej Vašek <mvasek@redhat.com>
@knative-prow knative-prow bot requested review from rhuss and vyasgun May 11, 2024 13:09
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 11, 2024
@matejvasek matejvasek requested review from lkingland, jrangelramos, gauron99 and lance and removed request for rhuss and vyasgun May 11, 2024 13:10
@matejvasek
Copy link
Contributor Author

PTAL @lance

Copy link

codecov bot commented May 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.72%. Comparing base (b97d841) to head (1998899).
Report is 83 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2295      +/-   ##
==========================================
- Coverage   64.21%   60.72%   -3.50%     
==========================================
  Files         108      127      +19     
  Lines       13918    14779     +861     
==========================================
+ Hits         8937     8974      +37     
- Misses       4108     4905     +797     
- Partials      873      900      +27     
Flag Coverage Δ
e2e-test 38.40% <ø> (+1.02%) ⬆️
e2e-test-oncluster 31.52% <ø> (+1.01%) ⬆️
e2e-test-oncluster-runtime 27.74% <ø> (?)
e2e-test-runtime-go 26.24% <ø> (?)
e2e-test-runtime-node 27.22% <ø> (?)
e2e-test-runtime-python 27.17% <ø> (?)
e2e-test-runtime-quarkus 27.26% <ø> (?)
e2e-test-runtime-rust 26.28% <ø> (?)
e2e-test-runtime-springboot 26.32% <ø> (?)
e2e-test-runtime-typescript 27.31% <ø> (?)
integration-tests 49.87% <ø> (+0.02%) ⬆️
unit-tests-macos-latest ?
unit-tests-ubuntu-latest 48.98% <ø> (-0.61%) ⬇️
unit-tests-windows-latest 47.59% <ø> (-1.28%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 13, 2024
Copy link

knative-prow bot commented May 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matejvasek, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@matejvasek
Copy link
Contributor Author

@dsimansk would you please override codecov/project, it seems to be stuck for some reason.

@dsimansk
Copy link
Contributor

/override codecov/project

Copy link

knative-prow bot commented May 13, 2024

@dsimansk: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • codecov/project

Only the following failed contexts/checkruns were expected:

  • EasyCLA
  • style / Golang
  • style / suggester / shell
  • style / suggester / yaml
  • tide
  • unit-tests_func_main

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override codecov/project

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dsimansk dsimansk closed this May 13, 2024
@dsimansk dsimansk reopened this May 13, 2024
@dsimansk
Copy link
Contributor

@matejvasek did a quick dirty close/open.

@knative-prow knative-prow bot merged commit 46f6f08 into knative:main May 13, 2024
63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants