Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove axios dependency #2294

Merged
merged 7 commits into from
May 11, 2024
Merged

Remove axios dependency #2294

merged 7 commits into from
May 11, 2024

Conversation

matejvasek
Copy link
Contributor

@matejvasek matejvasek commented May 10, 2024 •
edited

Changes

  • Removed dependency on axios by using fetch().
  • Fixed getLatestPlatform() by using the tag_name property instead of the name property.
  • Updated setup-java GH action version
  • Added some missing properties to GH action files.

@matejvasek
fix: downgrade Java version for Spring Boot
fcfe65a 
The newer version of Spring Boot does not work with Java 21

Signed-off-by: Matej Vašek <mvasek@redhat.com>
@matejvasek
chore: replace axios with fetch()
eb1337e 
* Removed dependency on axios by using standard node fetch() function.
* Fixed getLatestPlatform(): using the 'tag_name' property instead of the 'name' property.

Signed-off-by: Matej Vašek <mvasek@redhat.com>
@matejvasek
Revert "fix: downgrade Java version for Spring Boot"
37d6749 
This reverts commit fcfe65a.
@knative-prow Knative Prow
Copy link

knative-prow bot commented May 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot requested review from jrangelramos and rhuss May 10, 2024 18:43
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 10, 2024
@matejvasek
empyt: just trigger CI
2c891f7 
Signed-off-by: Matej Vašek <mvasek@redhat.com>
@matejvasek matejvasek added the lgtm Indicates that a PR is ready to be merged. label May 10, 2024
@codecov Codecov
Copy link

codecov bot commented May 10, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.72%. Comparing base (b97d841) to head (04c4c6c).
Report is 79 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2294      +/-   ##
==========================================
- Coverage   64.21%   60.72%   -3.50%     
==========================================
  Files         108      127      +19     
  Lines       13918    14779     +861     
==========================================
+ Hits         8937     8974      +37     
- Misses       4108     4905     +797     
- Partials      873      900      +27
Flag Coverage Δ
e2e-test 38.40% <ø> (+1.02%) ⬆️
e2e-test-oncluster 31.52% <ø> (+1.01%) ⬆️
e2e-test-oncluster-runtime 27.67% <ø> (?)
e2e-test-runtime-go 26.21% <ø> (?)
e2e-test-runtime-node 27.22% <ø> (?)
e2e-test-runtime-python 27.15% <ø> (?)
e2e-test-runtime-quarkus 27.26% <ø> (?)
e2e-test-runtime-rust 26.31% <ø> (?)
e2e-test-runtime-springboot 26.33% <ø> (?)
e2e-test-runtime-typescript 27.31% <ø> (?)
integration-tests 49.92% <ø> (+0.06%) ⬆️
unit-tests-macos-latest 47.89% <ø> (-0.95%) ⬇️
unit-tests-ubuntu-latest 48.98% <ø> (-0.61%) ⬇️
unit-tests-windows-latest 47.60% <ø> (-1.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matejvasek
chore: update setup-java action
b6da3c2 
Signed-off-by: Matej Vašek <mvasek@redhat.com>
@matejvasek
fix: add missing description property
daa49fb 
Signed-off-by: Matej Vašek <mvasek@redhat.com>
@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label May 11, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented May 11, 2024

New changes are detected. LGTM label has been removed.

@matejvasek matejvasek added the lgtm Indicates that a PR is ready to be merged. label May 11, 2024
@matejvasek
fix: set distroless for setup-java action
04c4c6c 
Signed-off-by: Matej Vašek <mvasek@redhat.com>
@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label May 11, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented May 11, 2024

New changes are detected. LGTM label has been removed.

@matejvasek matejvasek added the lgtm Indicates that a PR is ready to be merged. label May 11, 2024
@knative-prow knative-prow bot merged commit 6649579 into knative:main May 11, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrangelramos jrangelramos Awaiting requested review from jrangelramos

@rhuss rhuss Awaiting requested review from rhuss

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@matejvasek