Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update node to v20 #2217

Merged
merged 4 commits into from Apr 30, 2024
Merged

Conversation

matejvasek
Copy link
Contributor

@matejvasek matejvasek commented Mar 12, 2024

  • Update Node to version 20 for the s2i build strategy
  • Ignore (till 2024-05-31) deletion error caused by Node having broken signal handling

Signed-off-by: Matej Vašek <mvasek@redhat.com>
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 12, 2024
@matzew
Copy link
Member

matzew commented Mar 13, 2024

--- FAIL: TestFunctionCloudEventsTemplate (262.24s)

@lkingland
Copy link
Member

/retest

Copy link

codecov bot commented Apr 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.70%. Comparing base (b97d841) to head (9479445).
Report is 70 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2217      +/-   ##
==========================================
- Coverage   64.21%   60.70%   -3.51%     
==========================================
  Files         108      127      +19     
  Lines       13918    14779     +861     
==========================================
+ Hits         8937     8972      +35     
- Misses       4108     4906     +798     
- Partials      873      901      +28     
Flag Coverage Δ
e2e-test 38.40% <ø> (+1.02%) ⬆️
e2e-test-oncluster 31.50% <ø> (+1.00%) ⬆️
e2e-test-oncluster-runtime 27.67% <ø> (?)
e2e-test-runtime-go 26.21% <ø> (?)
e2e-test-runtime-node 27.22% <ø> (?)
e2e-test-runtime-python 27.17% <ø> (?)
e2e-test-runtime-quarkus 27.26% <ø> (?)
e2e-test-runtime-rust 26.31% <ø> (?)
e2e-test-runtime-typescript 27.31% <ø> (?)
integration-tests 49.87% <ø> (+0.02%) ⬆️
unit-tests-macos-latest ?
unit-tests-ubuntu-latest 48.98% <ø> (-0.61%) ⬇️
unit-tests-windows-latest 47.60% <ø> (-1.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Matej Vašek <mvasek@redhat.com>
@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 30, 2024
Signed-off-by: Matej Vašek <mvasek@redhat.com>
@matejvasek
Copy link
Contributor Author

@matejvasek matejvasek requested review from matzew, gauron99 and lkingland and removed request for rhuss April 30, 2024 14:18
Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 30, 2024
Copy link

knative-prow bot commented Apr 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matejvasek, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 7c87e0c into knative:main Apr 30, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants